Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code blocks for the ch11 (suites) #24

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Conversation

bocharsky-bw
Copy link
Member

Resolve ch11-suites in #12

@weaverryan
Copy link
Member

👍 - nice job including the CommandLineProcessContext to show "all" of it, but try to hide some less important pieces for space. I did change a few code blocks on this one - for behat.yml - sometimes we would hide the default and suites keys, so when you looked at the code-block, the code we showed was kind of floating in the middle of nowhere - the context wasn't obvious enough. Here's an example:

screen shot 2015-11-09 at 6 36 26 pm

If you ever disagree, let me know! We're both 2 developers, finding the perfect balance that we would want included (and either way, it's not a huge deal, since the code blocks expand - yay!) :)

weaverryan added a commit that referenced this pull request Nov 9, 2015
Add code blocks for the ch11 (suites)
@weaverryan weaverryan merged commit dfcabcb into behat3 Nov 9, 2015
@weaverryan weaverryan deleted the code-blocks-ch11 branch November 9, 2015 23:37
@bocharsky-bw
Copy link
Member Author

👍 for saving space! Anyways, code blocks really can be expanded if need :)

@weaverryan
Copy link
Member

@bocharsky-bw actually, I did the opposite - I added a little bit more code to the screenshot (screenshot was the original) - I changed it to include more lines by default 😇

@bocharsky-bw
Copy link
Member Author

Oh, I understood an idea wrong :)

I shorten it sometimes.. I'll try to add more context in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants